fix: ignore export assign cannot be used in module TS error, fixes #1018 #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: ignore export assign cannot be used in module TS error, fixes #1018
This was referenced Nov 14, 2024
Contributor
Author
|
@reduckted could you review the PR? |
Contributor
|
Looks good. Thanks for investigating and finding a fix! ❤️ |
Owner
|
Thanks everyone! |
luxaritas
pushed a commit
to luxaritas/DOMPurify
that referenced
this pull request
Nov 19, 2024
feature: Added configurability for text & HTML integration points
ssi02014
pushed a commit
to ssi02014/DOMPurify
that referenced
this pull request
Jul 27, 2025
feature: Added configurability for text & HTML integration points
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1018
Summary
Fixes issue #1018 by simply ignoring the TypeScript error since the TS error has no negative effect whatsoever on the functionality of these types. This makes TypeScript and "Are the Types Wrong" both happy and everything is back to normal and we can get back to work (finally).
The quick explanation is that sometime even when using ESM imports, CJS types exports get picked up (depending on the users tsconfig module resolutions) and
export = ...is a TypeScript error, but we can easily patch it by ignoring it.Background & Context
I found this article Default exports in CommonJS libraries which explains why
export = _defaultwas patched in the first place. However this gives a TypeScript error in some cases (depending on your tsconfig module resolutions and other configs), this error can simply be ignored altogether because the types still work correctly, the error when active though will block a TypeScript build, however simply ignoring the error will let us continue with our build successfully.Tasks
I simply modified the existing
fix-cjs-types.jsscript and ran a build.This also keeps "Are the Types Wrong" happy since nothing really changed for the types themselves, so all is good and we're all happy 🎉
Dependencies